The result isn't perfect but hopefully a notable improvement which will be coming to an Openstack review site near you soon. Here is the before and after shots:
The /dev/null ramblings of a Linux Jedi
Tuesday 13 March 2012
Changes coming to Gerrit's style
Gerrit is a fantastic tool for performing code reviews and automating many of the tasks which can become quite complex. Unfortunately its default style is not the most attractive thing to look at all day. Yesterday I was tasked with skinning Gerrit to make it more in-line with Openstack. This was not as easy a task as I first anticipated, mostly down to not having the ability to edit the HTML layout very much without editing Gerrit's source.
The result isn't perfect but hopefully a notable improvement which will be coming to an Openstack review site near you soon. Here is the before and after shots:
The result isn't perfect but hopefully a notable improvement which will be coming to an Openstack review site near you soon. Here is the before and after shots:
Subscribe to:
Post Comments (Atom)
Cool!
ReplyDeleteHow about linking user profiles in Gerrit to their Launchpad profiles? is it possible?
Currently it takes some time to find who stands behind a review here and there, e.g. to connect over IRC. While this info is usually shared in Launchpad profiles, there is no link to follow in user's Gerrit change list that could point to Launchpad.
Technically that may be possible but I don't think we retrieve enough info from Launchpad at sync time to do this yet. You are welcome to file a request for it at:
Deletehttps://bugs.launchpad.net/openstack-ci
It would be cool to abstract the templating out and submit a patch upstream... Good work though, thanks!
ReplyDeleteWhat I have done is quite a big hack onto something designed for very small changes to Gerrit's style. To do something that we could push upstream would require a lot of work.
DeleteWe are, of course, happy for anyone to poach our work and improve on it. It will be publicly available in the openstack-ci-puppet repository hopefully later this week. At some point I will document it too.
This is AWESOME. I'm gonna build on this so that we at the Wikimedia Foundation can style Gerrit to our tastes and implement small interface enhancements in JavaScript.
ReplyDelete